From d505017cec86c000f891b003f5ca3481f5ffae61 Mon Sep 17 00:00:00 2001 From: Berke Güzel Date: Mon, 12 Oct 2026 17:54:48 +0300 Subject: term: fix the two Kitty suite failures and run the suite by default Both failures were stale expectations in our copy of the suite. 8c2464c moved the terminal to xterm behavior and added spec tests for it. The Kitty bridge did not compile then, so nobody updated the suite. - A cursor report with a pending wrap gives the last column (1;5). Kitty gives the start of the next line. - HT only moves the cursor. Kitty writes a tab cell, which erases the text under the tab. REP after the tab then repeats nothing. The suite went weeks without running, because it needed -Dkitty_tests=true. Now every unsanitized Linux build runs it in the unit suite, and the main option only makes it mandatory. The README lists the deliberate differences from Kitty. Co-Authored-By: Claude Opus 5.5 --- tests/meson.build | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) (limited to 'tests/meson.build') diff --git a/tests/meson.build b/tests/meson.build index 42c442e..8372574 100644 --- a/tests/meson.build +++ b/tests/meson.build @@ -109,10 +109,14 @@ test('term-cross-test', bash, timeout: 600, ) -if get_option('kitty_tests') - if host_machine.system() != 'linux' or get_option('b_sanitize') != 'none' - error('Kitty tests require an unsanitized Linux build') - endif +# The bridge is a shared library that Python loads, so a sanitized build +# cannot run it. +kitty_tests = get_option('kitty').require( + host_machine.system() == 'linux' and get_option('b_sanitize') == 'none', + error_message: 'The Kitty tests need an unsanitized Linux build', +) +term_kitty_tests = kitty_tests.allowed() +if term_kitty_tests kitty_bridge = shared_library('term', 'extern/kitty/screen_bridge.c', dependencies: term_internal_dep, ) @@ -122,7 +126,7 @@ if get_option('kitty_tests') args: files('extern/kitty/parser.py'), depends: kitty_bridge, env: kitty_env, - suite: 'kitty', + suite: ['unit', 'kitty'], is_parallel: false, ) endif -- cgit v1.2.3